Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Add api definitions #2

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Add api definitions #2

merged 2 commits into from
Nov 17, 2020

Conversation

brahmaroutu
Copy link
Contributor

This PR adds hack/codegen.sh to generate the API controller artifacts for all the API's defined under apis/objectstorage.k8s.io/v1alpha1. All CRD definitions along with listers informers and clientset are also checked-in for this package to be consumable as is.

@wlan0 @xing-yang Please review

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 28, 2020
wlan0
wlan0 suggested changes Oct 29, 2020
View reviewed changes
apis/objectstorage.k8s.io/v1alpha1/azure_types.go
@@ -0,0 +1,8 @@
// +k8s:deepcopy-gen=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

apis/objectstorage.k8s.io/v1alpha1/s3_types.go Outdated
type S3SignatureVersion string

const (
S3SignatureVersionV2 = "s3v2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, changes it to uppercase as suggested.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2020
wlan0
wlan0 reviewed Nov 2, 2020
View reviewed changes
apis/objectstorage.k8s.io/v1alpha1/types.go Outdated
metav1.TypeMeta `json:",inline"`
// +optional
metav1.ObjectMeta `json:"metadata,omitempty"`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

wlan0
wlan0 reviewed Nov 2, 2020
View reviewed changes
apis/objectstorage.k8s.io/v1alpha1/types.go Outdated

// +optional
Principal string `json:"principal,omitempty"`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@wlan0
Copy link
Contributor

wlan0 commented Nov 2, 2020

Mostly just nits, and one concern with ObjectReference. Otherwise, LGTM.

@brahmaroutu
Copy link
Contributor Author

@wlan0 @rrati
Can you please review

rrati
rrati approved these changes Nov 4, 2020
View reviewed changes
Copy link

@rrati rrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brahmaroutu, rrati, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brahmaroutu,rrati,wlan0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jeffvance
jeffvance reviewed Nov 17, 2020
View reviewed changes
apis/objectstorage.k8s.io/v1alpha1/azure_types.go

// +k8s:deepcopy-gen=false

package v1alpha1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need protocol-specific types now? I may be a bit behind, but I thought the Bucket instance was no longer going to expose protocol-specific fields, other than, perhaps, common values for all protocols.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffvance This PR is inline with the KEP that is merged. We will iterate it when the new proposal is merged.

@k8s-ci-robot
Copy link
Contributor

@brahmaroutu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wlan0
Copy link
Contributor

wlan0 commented Nov 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5547754 into kubernetes-retired:master Nov 17, 2020
@xing-yang xing-yang mentioned this pull request Nov 23, 2020
Merged
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request May 29, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#2 from krishchow/issue_template
90da483 
adds issue templates to the COSI controller
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#2 from krishchow/issue_template
55c8e6d 
adds issue templates to the COSI controller
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#2 from brahmaroutu/add_approvers
784bb4a 
Add approvers to facilitate project management
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#2 from brahmaroutu/add_approvers
9dbbf25 
Add approvers to facilitate project management
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffvance jeffvance jeffvance left review comments

@rrati rrati rrati approved these changes

@wlan0 wlan0 wlan0 approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brahmaroutu @wlan0 @k8s-ci-robot @rrati @jeffvance